Skip to content

This PR is to add comments to TestGenerateJindoValueFile in /pkg/ddc/jindo/master_internal_test.go. #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheyang merged 1 commit into from
Mar 19, 2025
Merged

This PR is to add comments to TestGenerateJindoValueFile in /pkg/ddc/jindo/master_internal_test.go. #4630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/ddc/jindo/master_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,15 @@ func TestSetupMasterInternal(t *testing.T) {
wrappedUnhookInstallRelease()
}

// TestGenerateJindoValueFile tests the functionality of generating Jindo value files for Fluid's JindoRuntime.
Copy link
Copy Markdown
Collaborator

@cheyang cheyang Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

// This test creates a mock environment with a JindoRuntime instance and associated Dataset,
// then verifies that the engine can properly generate configuration values without errors.
// The test covers:
// - Setting up a JindoRuntime with specific tiered storage configuration
// - Creating a fake client with test objects
// - Building runtime information
// - Configuring port allocation
// - Validating the value file generation process
func TestGenerateJindoValueFile(t *testing.T) {
jindoruntime := &datav1alpha1.JindoRuntime{
ObjectMeta: metav1.ObjectMeta{
Expand Down
Loading