This PR is to add comments to TestAlluxioEngine_GetDeprecatedCommonLabelname in pkg…#4648
This PR is to add comments to TestAlluxioEngine_GetDeprecatedCommonLabelname in pkg…#4648TrafalgarZZZ merged 3 commits intofluid-cloudnative:masterfrom zhuchaowen:myfluid
Conversation
…\ddc\alluxio\deprecated_label_test.go Signed-off-by: zhuchaowen <zhuchaowen20@gmail.com>
|
Hi @zhuchaowen. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…\ddc\alluxio\deprecated_label_test.go Signed-off-by: zhuchaowen <zhuchaowen20@gmail.com>
| return engine | ||
| } | ||
|
|
||
| // TestAlluxioEngine_GetDeprecatedCommonLabelname 测试 GetCommonLabelName 函数， |
There was a problem hiding this comment.
Please add comments in English.
|
…\ddc\alluxio\deprecated_label_test.go Signed-off-by: zhuchaowen <zhuchaowen20@gmail.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TrafalgarZZZ
merged commit 007cc06
into
fluid-cloudnative:master
3 participants
…\ddc\alluxio\deprecated_label_test.go
Ⅰ. Describe what this PR does
add comments to TestAlluxioEngine_GetDeprecatedCommonLabelname in pkg\ddc\alluxio\deprecated_label_test.go
Ⅱ. Does this pull request fix one issue?
fixes #4646
fixes #4665
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews