Skip to content

Add comments to TestShouldRestoreMetadata in pkg\ddc\alluxio\metadata_test.go#4659

Merged
fluid-e2e-bot[bot] merged 3 commits intofluid-cloudnative:masterfrom
leowhr:branch_Whr
Mar 20, 2025
Merged

Add comments to TestShouldRestoreMetadata in pkg\ddc\alluxio\metadata_test.go#4659
fluid-e2e-bot[bot] merged 3 commits intofluid-cloudnative:masterfrom
leowhr:branch_Whr

Conversation

@leowhr
Copy link
Copy Markdown
Contributor

@leowhr leowhr commented Mar 13, 2025

Ⅰ. Describe what this PR does

Add comments to the function TestShouldRestoreMetadata.

Ⅱ. Does this pull request fix one issue?

fixes #4658

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No tests are needed, as I just added a comment.

Ⅳ. Describe how to verify it

None.

Ⅴ. Special notes for reviews

None.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 13, 2025

Hi @leowhr. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

JiGuoDing commented Mar 14, 2025

Hello @leowhr, please fix the DCO Issue by following https://github.com/fluid-cloudnative/fluid/pull/4659/checks?check_run_id=38715733145.

Moreover, please use // for comments instead of /**/. Thanks.

@leowhr
modify1
9027620 
Signed-off-by: wanghaoran <1948735040@qq.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
100.0% Duplication on New Code

See analysis details on SonarQube Cloud

@leowhr
Copy link
Copy Markdown
Contributor Author

leowhr commented Mar 17, 2025

Hello @JiGuoDing , I've updated the code based on your feedback. Please review it again.

cheyang
cheyang approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Mar 20, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Mar 20, 2025

/ok-to-test

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 73aae73 into fluid-cloudnative:master Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comments to TestShouldRestoreMetadata in pkg\ddc\alluxio\metadata_test.go

3 participants

@leowhr @JiGuoDing @cheyang