Skip to content

This PR is to add Comments to TestJuiceFSEngine_genDataUrl_PVC in pkg/ddc/juicefs/d…#4705

Closed
zjl2803868897 wants to merge 1 commit intofluid-cloudnative:masterfrom
zjl2803868897:new-branch
Closed

This PR is to add Comments to TestJuiceFSEngine_genDataUrl_PVC in pkg/ddc/juicefs/d…#4705
zjl2803868897 wants to merge 1 commit intofluid-cloudnative:masterfrom
zjl2803868897:new-branch

Conversation

@zjl2803868897
Copy link
Copy Markdown

Ⅰ. Describe what this PR does

add Comments to TestJuiceFSEngine_genDataUrl_PVC in pkg/ddc/juicefs/d…

Ⅱ. Does this pull request fix one issue?

fixes #4694

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…ata_migrate_test.go

Signed-off-by: zjl2803868897 <jiale2743@gmail.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ronggu for approval by writing /assign @ronggu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 16, 2025

Hi @zjl2803868897. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @zjl2803868897,

  • please ensure that the comments are in English;
  • please leave one blank line between your comments and the function preceding the one you are commenting on.

Thanks.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments in English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestJuiceFSEngine_genDataUrl_PVC in /pkg/ddc/juicefs/data_migrate_test.go

4 participants