Skip to content

juicefs: support extra options in dataload#4760

Merged
cheyang merged 4 commits intofluid-cloudnative:masterfrom
zwwhdls:juicefs/warmup_option
Mar 27, 2025
Merged

juicefs: support extra options in dataload#4760
cheyang merged 4 commits intofluid-cloudnative:masterfrom
zwwhdls:juicefs/warmup_option

Conversation

@zwwhdls
Copy link
Copy Markdown
Member

@zwwhdls zwwhdls commented Mar 18, 2025

Ⅰ. Describe what this PR does

juicefs: support extra options in dataload

Ⅱ. Does this pull request fix one issue?

close #4501

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls zwwhdls requested review from TrafalgarZZZ and cheyang March 18, 2025 02:59
zwwhdls added 3 commits March 18, 2025 11:03
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
@sonarqubecloud
Copy link
Copy Markdown

- name: TIMEOUT
value: {{ $val | quote }}
{{- end }}
{{- if eq $key "option" }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering potential security risk.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit aba6d90 into fluid-cloudnative:master Mar 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURES] Support for DataLoad Configuration Options in JuiceFS Runtime

2 participants