Skip to content

This PR is to add comments to TestGetFSInfoFromConfigMap in pkg/ddc/juicefs/datasetinfo_parser_test.go#4773

Merged
cheyang merged 3 commits intofluid-cloudnative:masterfrom
tongyf2333:new-branch
Mar 31, 2025
Merged

This PR is to add comments to TestGetFSInfoFromConfigMap in pkg/ddc/juicefs/datasetinfo_parser_test.go#4773
cheyang merged 3 commits intofluid-cloudnative:masterfrom
tongyf2333:new-branch

Conversation

@tongyf2333
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does
This PR is to add comments to TestGetFSInfoFromConfigMap in pkg/ddc/juicefs/datasetinfo_parser_test.go
Ⅱ. Does this pull request fix one issue?
fixes #4633
Ⅲ. Special notes for reviews

tongyf added 2 commits March 12, 2025 01:59
…setinfo_parser_test.go

Signed-off-by: tongyf <tongyf@meow.com>
…info_parser_test.go

Signed-off-by: tongyf <tongyf@meow.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 18, 2025

Hi @tongyf2333. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @tongyf2333, please do not leave a blank line between your comments and the function you are commenting on. Thanks.

…info_parser_test.go

Signed-off-by: tongyf <tongyf@meow.com>
@sonarqubecloud
Copy link
Copy Markdown

@tongyf2333
Copy link
Copy Markdown
Contributor Author

Hello @tongyf2333, please do not leave a blank line between your comments and the function you are commenting on. Thanks.

Okay,I pushed my code again.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 20, 2025

@tongyf2333: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 5db342d into fluid-cloudnative:master Mar 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestGetFSInfoFromConfigMap in pkg/ddc/juicefs/datasetinfo_parser_test.go

3 participants