Skip to content

This PR is to add comments to TestGetCacheInfoFromConfigmap(t *testing.T) in pkg\ddc\j uicefs\datasetinfo_parser_test.go.#4776

Merged
cheyang merged 1 commit intofluid-cloudnative:masterfrom
1501634824:new-branch
Jun 3, 2025
Merged

This PR is to add comments to TestGetCacheInfoFromConfigmap(t *testing.T) in pkg\ddc\j uicefs\datasetinfo_parser_test.go.#4776
cheyang merged 1 commit intofluid-cloudnative:masterfrom
1501634824:new-branch

Conversation

@1501634824
Copy link
Copy Markdown
Contributor

@1501634824 1501634824 commented Mar 18, 2025

…c\juicefs\datasetinfo_parser_test.go.

Ⅰ. Describe what this PR does

Add notation to TestGetCacheInfoFromConfigmap(t *testing.T) in pkg\ddc\j
uicefs\datasetinfo_parser_test.go.

Ⅱ. Does this pull request fix one issue?

fixes #5006

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 18, 2025

Hi @1501634824. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @1501634824, please ensure that your comments are in English. Thanks

1 similar comment
@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @1501634824, please ensure that your comments are in English. Thanks

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments in English.

…setinfo_parser_test.go

Signed-off-by: 1501634824 <1501634824@qq.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2025

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 5229f12 into fluid-cloudnative:master Jun 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestGetCacheInfoFromConfigmap in pkg\ddc\juicefs\datasetinfo_parser_test.go

3 participants