Skip to content

Revert github.com/prometheus/client_golang to v1.20.5#4795

Merged
cheyang merged 3 commits intofluid-cloudnative:masterfrom
TrafalgarZZZ:minorfix/pin_prometheus_client_golang_to_v1.20.5
Mar 20, 2025
Merged

Revert github.com/prometheus/client_golang to v1.20.5#4795
cheyang merged 3 commits intofluid-cloudnative:masterfrom
TrafalgarZZZ:minorfix/pin_prometheus_client_golang_to_v1.20.5

Conversation

@TrafalgarZZZ
Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Revert github.com/prometheus/client_golang to v1.20.5 to avoid patch failure on darwin platform.

github.com/brahma-adshonor/gohook.hookFunction(0x40, 0x0, 0x106831fc0, 0x106950c20, 0x0)
        /Users/zhxu/go/src/github.com/fluid-cloudnative/fluid/vendor/github.com/brahma-adshonor/gohook/utility.go:218 +0x53c
github.com/brahma-adshonor/gohook.doHook(0x40, 0x0, {0x106cf9680?, 0x106f9d980?, 0xc000100008?}, {0x106cf9680?, 0x106f9d910?, 0x0?}, {0x0, 0x0, ...})
        /Users/zhxu/go/src/github.com/fluid-cloudnative/fluid/vendor/github.com/brahma-adshonor/gohook/hook.go:164 +0x4b7
github.com/brahma-adshonor/gohook.Hook({0x106cf9680?, 0x106f9d980?}, {0x106cf9680?, 0x106f9d910?}, {0x0?, 0x0?})
        /Users/zhxu/go/src/github.com/fluid-cloudnative/fluid/vendor/github.com/brahma-adshonor/gohook/hook.go:71 +0x16b
github.com/fluid-cloudnative/fluid/pkg/ddc/efc.TestEFCEngine_CheckRuntimeReady(0xc0005a64e0)
        /Users/zhxu/go/src/github.com/fluid-cloudnative/fluid/pkg/ddc/efc/data_load_test.go:189 +0x8bb
testing.tRunner(0xc0005a64e0, 0x106f9d6a0)
        /Users/zhxu/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.7.darwin-amd64/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 1
        /Users/zhxu/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.7.darwin-amd64/src/testing/testing.go:1743 +0x390
FAIL    github.com/fluid-cloudnative/fluid/pkg/ddc/efc  3.397s
--- FAIL: TestEFCFileUtils_exec (0.00s)
panic: permission denied [recovered]
        panic: permission denied

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Comment thread go.mod Outdated
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 53c346d into fluid-cloudnative:master Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants