Skip to content

Add comments to invokeCleanCache in pkg\ddc\goosefs\cache.go#4808

Merged
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
chhnb:new-branch
Apr 9, 2025
Merged

Add comments to invokeCleanCache in pkg\ddc\goosefs\cache.go#4808
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
chhnb:new-branch

Conversation

@chhnb
Copy link
Copy Markdown
Contributor

@chhnb chhnb commented Mar 23, 2025

Ⅰ. Describe what this PR does

Add comments to invokeCleanCache in pkg\ddc\goosefs\cache.go

Ⅱ. Does this pull request fix one issue?

fixes #4807

Ⅲ. Special notes for reviews

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 23, 2025

Hi @chhnb. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @chhnb, please fix the DCO Issue by following https://github.com/fluid-cloudnative/fluid/pull/4808/checks?check_run_id=39246041700. Thanks.

@chhnb
Copy link
Copy Markdown
Contributor Author

chhnb commented Mar 24, 2025

Hello @chhnb, please fix the DCO Issue by following https://github.com/fluid-cloudnative/fluid/pull/4808/checks?check_run_id=39246041700. Thanks.

Thank you for your reminder, I have already fixed this comment.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Apr 9, 2025

@dependabot rebase

Signed-off-by: chh <522024330002@smail.nju.edu.cn>
Signed-off-by: cheyang <cheyang@163.com>
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Apr 9, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2025

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 32c8284 into fluid-cloudnative:master Apr 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to invokeCleanCache in pkg\ddc\goosefs\cache.go

3 participants