This PR is to add comments/notation to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.#4852
Closed
ackerm0n wants to merge 0 commit intofluid-cloudnative:masterfrom
Closed
This PR is to add comments/notation to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.#4852ackerm0n wants to merge 0 commit intofluid-cloudnative:masterfrom
ackerm0n wants to merge 0 commit intofluid-cloudnative:masterfrom
Conversation
Collaborator
|
@ackerm0n Please check your change by running the following command Please run make fmt to verify gofmt
Error: Process completed with exit code 1. |
cheyang
requested changes
Apr 28, 2025
Collaborator
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
Please fix the conflict issue. Thanks.
Contributor
Author
|
@cheyang The problems have been solved. |
cheyang
force-pushed
the
new-branch
branch
2 times, most recently
from
081a81c to
cb61582
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Collaborator
|
@ackerm0n Please create a new PR, and make sure the changes are only about the comments of function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR is to add comments/notation to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.
Ⅱ. Does this pull request fix one issue?
fixes #4851（之前创建的issue的id）
Ⅲ. Special notes for reviews