Skip to content

This PR is to add comments to checkMasterHealthy in pkg/ddc/goosefs/health_check.go #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 2 commits into from
May 19, 2025
Merged

This PR is to add comments to checkMasterHealthy in pkg/ddc/goosefs/health_check.go #4882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca217ab
Add comments/notation to checkMasterHealthy in pkg/ddc/goosefs/health…
miledragon May 14, 2025
a804f83
add comments to checkMasterHealthy in pkg/ddc/goosefs/health_check.go
miledragon May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pkg/ddc/goosefs/health_check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,18 @@ func (e *GooseFSEngine) CheckRuntimeHealthy() (err error) {
return
}

// checkMasterHealthy checks the master healthy
// checkMasterHealthy checks whether the GooseFS master StatefulSet is healthy.
// It compares the desired and ready replica counts of the master StatefulSet.
// If the master is not healthy, it updates the runtime status to NotReady with the appropriate condition.
// If the master is healthy, it updates the status to Ready.
// The function uses a retry mechanism to handle conflicts when updating the runtime status.
//
// Parameters:
// - none (uses fields from the GooseFSEngine receiver)
//
// Returns:
// - error: returns an error if the master is not healthy or if the runtime status update fails.

func (e *GooseFSEngine) checkMasterHealthy() (err error) {
masterName := e.getMasterName()

Expand Down