Skip to content

This PR is to add comments to TestCheckIfRemountRequired(t *testing.T) in pkg\ddc\alluxio\ufs_test.go.#4895

Merged
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
HDZsuper:new-branch
May 25, 2025
Merged

This PR is to add comments to TestCheckIfRemountRequired(t *testing.T) in pkg\ddc\alluxio\ufs_test.go.#4895
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
HDZsuper:new-branch

Conversation

@HDZsuper
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does
add comments to TestCheckIfRemountRequired(t *testing.T) in pkg\ddc\alluxio\ufs_test.go.

Ⅱ. Does this pull request fix one issue?
fixes #4894

Ⅲ. Special notes for reviews
Bigdata

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 20, 2025

Hi @HDZsuper. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

HDZsuper and others added 2 commits May 25, 2025 10:16
…pkg\ddc\alluxio\ufs_test.go.

Signed-off-by: HDZ <1416453048@qq.com>
Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label May 25, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 0494782 into fluid-cloudnative:master May 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments/notation to TestCheckIfRemountRequired(t *testing.T) in pkg\ddc\alluxio\ufs_test.go

2 participants