Skip to content

This PR is to add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluxio/transform_optimization_test.go#4919

Closed
xxxxxxyp wants to merge 4 commits intofluid-cloudnative:masterfrom
xxxxxxyp:patch-1
Closed

This PR is to add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluxio/transform_optimization_test.go#4919
xxxxxxyp wants to merge 4 commits intofluid-cloudnative:masterfrom
xxxxxxyp:patch-1

Conversation

@xxxxxxyp
Copy link
Copy Markdown

@xxxxxxyp xxxxxxyp commented May 27, 2025

Ⅰ. Describe what this PR does
This PR adds comments to the 'TestOptimizeDefaultForFuseWithValue' function in pkg/ddc/alluxio/transform_optimization_test.go, clarifying its purpose of updating dataset phase, conditions, and cache status based on runtime configuration. The comments follow the specified format and are placed before the function definition.

Ⅱ. Does this pull request fix one issue?
fixes #4918

Ⅲ. Special notes for reviews
No special notes. The comments adhere to the required format and have been verified against the function's logic for updating Alluxio dataset status.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 27, 2025

Hi @xxxxxxyp. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xxxxxxyp xxxxxxyp changed the title This PR This PR is to add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluexio/transform_optimization_test.go May 27, 2025
@xxxxxxyp xxxxxxyp changed the title This PR is to add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluexio/transform_optimization_test.go This PR is to add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluxio/transform_optimization_test.go May 27, 2025
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang self-requested a review May 28, 2025 09:13
@xxxxxxyp xxxxxxyp closed this May 29, 2025
@xxxxxxyp xxxxxxyp reopened this May 30, 2025
xxxxxxyp added 4 commits May 30, 2025 08:09
…o/transform_optimization_test.go

Signed-off-by: xxxxxxyp <xxxxxxyp@126.com>
Signed-off-by: xxxxxxyp <xxxxxxyp@126.com>
This reverts commit 3c39767.

Signed-off-by: xxxxxxyp <xxxxxxyp@126.com>
Signed-off-by: xxxxxxyp <xxxxxxyp@126.com>
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluxio/transform_optimization_test.go

3 participants