Skip to content

This PR is to add comments to TestCheckMasterReady in pkg/ddc/alluxio/master_test.go#4922

Merged
cheyang merged 2 commits intofluid-cloudnative:masterfrom
poem12138:newbranch
Jun 10, 2025
Merged

This PR is to add comments to TestCheckMasterReady in pkg/ddc/alluxio/master_test.go#4922
cheyang merged 2 commits intofluid-cloudnative:masterfrom
poem12138:newbranch

Conversation

@poem12138
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

Add comments to the TestCheckMasterReady function in pkg/ddc/alluxio/master_test.go.

Ⅱ. Does this pull request fix one issue?

fixes #1

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases added. This PR only adds code comments.

Ⅳ. Describe how to verify it

Check the comments above the TestCheckMasterReady function to ensure they are clear, accurate, and correctly placed before the function.

Ⅴ. Special notes for reviews

None.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 27, 2025

Hi @poem12138. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poem12138 poem12138 changed the title Add comments to TestCheckMasterReady in pkg/ddc/alluxio/master_test.go This PR is to add comments to TestCheckMasterReady in pkg/ddc/alluxio/master_test.go May 27, 2025
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Signed-off-by: unknown <221220118@smail.nju.edu.cn>
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added lgtm and removed lgtm labels May 31, 2025
Signed-off-by: unknown <221220118@smail.nju.edu.cn>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2025

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Jun 10, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 43d5b98 into fluid-cloudnative:master Jun 10, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create docs for dev

2 participants