Skip to content

This PR is to add comments to TestGenerateAlluxioValueFile in pkg/ddc/alluxio/master_internal_test.go#4965

Closed
ClearYesterday wants to merge 1 commit intofluid-cloudnative:masterfrom
ClearYesterday:new-branch
Closed

This PR is to add comments to TestGenerateAlluxioValueFile in pkg/ddc/alluxio/master_internal_test.go#4965
ClearYesterday wants to merge 1 commit intofluid-cloudnative:masterfrom
ClearYesterday:new-branch

Conversation

@ClearYesterday
Copy link
Copy Markdown

Ⅰ. Describe what this PR does
This PR is to add comments to TestGenerateAlluxioValueFile in pkg/ddc/alluxio/master_internal_test.go
Ⅱ. Does this pull request fix one issue?
fixes #4964
Ⅲ. Special notes for reviews

…r_internal_test.go.

Signed-off-by: Zrq436 <1448853658@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 30, 2025

Hi @ClearYesterday. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint issue.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cheyang by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestGenerateAlluxioValueFile in pkg/ddc/alluxio/master_internal_test.go.

3 participants