Skip to content

This PR is to add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go.#4976

Merged
fluid-e2e-bot[bot] merged 4 commits intofluid-cloudnative:masterfrom
jjqqcj:wocaocaole
Jun 13, 2025
Merged

This PR is to add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go.#4976
fluid-e2e-bot[bot] merged 4 commits intofluid-cloudnative:masterfrom
jjqqcj:wocaocaole

Conversation

@jjqqcj
Copy link
Copy Markdown
Contributor

@jjqqcj jjqqcj commented May 30, 2025

Ⅰ. Describe what this PR does
Add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go

Ⅱ. Does this pull request fix one issue?
fixes #4927

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 30, 2025

Hi @jjqqcj. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make fmt before submitting changes.

@jjqqcj
Copy link
Copy Markdown
Contributor Author

jjqqcj commented Jun 2, 2025

@cheyang 老师您好,麻烦帮忙审核一下这个 PR,DCO 和 lint 检查已通过,感谢!

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2025

@jjqqcj
Copy link
Copy Markdown
Contributor Author

jjqqcj commented Jun 3, 2025

@cheyang All checks have passed .
Could you please help review and approve this PR when you have a moment?
Thanks in advance!

@jjqqcj
Copy link
Copy Markdown
Contributor Author

jjqqcj commented Jun 12, 2025

@cheyang 老师您好,麻烦帮忙审核一下这个 PR,DCO 和 lint 检查已通过,感谢!

Copy link
Copy Markdown
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit f8848df into fluid-cloudnative:master Jun 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go

3 participants