Skip to content

This PR is to add comments to TestBuild in pkg/ddc/alluxio/engine_test.go.#5003

Merged
TrafalgarZZZ merged 3 commits intofluid-cloudnative:masterfrom
shiyi10:feature-221220072
Jun 16, 2025
Merged

This PR is to add comments to TestBuild in pkg/ddc/alluxio/engine_test.go.#5003
TrafalgarZZZ merged 3 commits intofluid-cloudnative:masterfrom
shiyi10:feature-221220072

Conversation

@shiyi10
Copy link
Copy Markdown
Contributor

@shiyi10 shiyi10 commented Jun 1, 2025

Ⅰ. Describe what this PR does
Add Notation to TestBuild in pkg/ddc/alluxio/engine_test.go.
Ⅱ. Does this pull request fix one issue?
fixes #5002
Ⅲ. Special notes for reviews

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 1, 2025

Hi @shiyi10. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Jun 2, 2025

/ok-to-test

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Signed-off-by: shiyi10 <2916736308@qq.com>
@fluid-e2e-bot fluid-e2e-bot Bot removed the lgtm label Jun 4, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2025

Copy link
Copy Markdown
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ TrafalgarZZZ merged commit 261fad7 into fluid-cloudnative:master Jun 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestBuild in pkg/ddc/alluxio/engine_test.go.

3 participants