Skip to content

Add Notation to TestSyncScheduleInfoToCacheNodes in pkg/ddc/jindo/nod…#5026

Merged
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
nartsing:new-branch
Jun 13, 2025
Merged

Add Notation to TestSyncScheduleInfoToCacheNodes in pkg/ddc/jindo/nod…#5026
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
nartsing:new-branch

Conversation

@nartsing
Copy link
Copy Markdown
Contributor

@nartsing nartsing commented Jun 3, 2025

I. Describe what this PR does
Add comments to TestSyncScheduleInfoToCacheNodes in pkg/ddc/jindo/node_test.go
II. Does this pull request fix one issue?
fixes #4782
III. Special notes for reviews

…e_test.go

Signed-off-by: 211870298@naqing <211870298@smail.nju.edu.cn>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2025

Hi @nartsing. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

…e_test.go

Signed-off-by: 211870298@naqing <211870298@smail.nju.edu.cn>
@fluid-e2e-bot fluid-e2e-bot Bot removed the lgtm label Jun 4, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2025

Copy link
Copy Markdown
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit b770e19 into fluid-cloudnative:master Jun 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Notation to TestSyncScheduleInfoToCacheNodes in pkg/ddc/jindo/node_test.go.

3 participants