Skip to content

This PR is to add comments to mockAlluxioEngineWithClient in pkg\ddc\alluxio\api_gateway_test.go#5034

Closed
abj1210 wants to merge 1 commit intofluid-cloudnative:masterfrom
abj1210:new-br
Closed

This PR is to add comments to mockAlluxioEngineWithClient in pkg\ddc\alluxio\api_gateway_test.go#5034
abj1210 wants to merge 1 commit intofluid-cloudnative:masterfrom
abj1210:new-br

Conversation

@abj1210
Copy link
Copy Markdown

@abj1210 abj1210 commented Jun 3, 2025

Add comments to mockAlluxioEngineWithClient in pkg\ddc\alluxio\api_gateway_test.go

Ⅰ. Describe what this PR does

Add comments to mockAlluxioEngineWithClient in pkg\ddc\alluxio\api_gateway_test.go

// mockAlluxioEngineWithClient creates a mock instance of AlluxioEngine with a fake client for testing purposes.
// This function initializes a mock Kubernetes service and associates it with the AlluxioEngine instance to simulate
// a real environment during unit tests.

// Parameters:
// - name (string): The name of the AlluxioEngine instance.
// - ns (string): The namespace where the AlluxioEngine instance will be created.
// - port (int32): The port number for the mock master service.

// Returns:
// - *AlluxioEngine: A pointer to the mock AlluxioEngine instance configured with the provided parameters and a fake client.

Ⅱ. Does this pull request fix one issue?

fixes #5031

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Add comments to mockAlluxioEngineWithClient in pkg\ddc\alluxio\api_gateway_test.go

Signed-off-by: abj1210 <87817992+abj1210@users.noreply.github.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2025

Hi @abj1210. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to mockAlluxioEngineWithClient in pkg\ddc\alluxio\api_gateway_test.go

2 participants