Skip to content

This PR is to add notation to checkWorkersHealthy in pkg\ddc\goosefs\health_check.go#5088

Merged
TrafalgarZZZ merged 1 commit intofluid-cloudnative:masterfrom
cristianowu7:whr
Jun 23, 2025
Merged

This PR is to add notation to checkWorkersHealthy in pkg\ddc\goosefs\health_check.go#5088
TrafalgarZZZ merged 1 commit intofluid-cloudnative:masterfrom
cristianowu7:whr

Conversation

@cristianowu7
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

This PR is to add notation to checkWorkersHealthy in pkg\ddc\goosefs\health_check.go

Ⅱ. Does this pull request fix one issue?

fixes #5087

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cristianowu7 <whr1462003385@gmail.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 8, 2025

Hi @cristianowu7. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 8, 2025

Copy link
Copy Markdown
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Jun 21, 2025

/ok-to-test
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ TrafalgarZZZ merged commit c5679c2 into fluid-cloudnative:master Jun 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Notation to checkWorkersHealthy in pkg\ddc\goosefs\health_check.go

3 participants