Skip to content

This PR is to add comments to HasDeprecatedCommonLabelname in pkg/ddc/goosefs/deprecated_label.go.#5093

Merged
fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
hongwangliu-nju:new-branch
Jun 25, 2025
Merged

This PR is to add comments to HasDeprecatedCommonLabelname in pkg/ddc/goosefs/deprecated_label.go.#5093
fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
hongwangliu-nju:new-branch

Conversation

@hongwangliu-nju
Copy link
Copy Markdown
Contributor

I. Describe what this PR does

// HasDeprecatedCommonLabelname checks whether the deprecated common label name exists.
// This method retrieves the DaemonSet's NodeSelector and determines if it contains the deprecated label name.
//
// Returns:
//
//	deprecated: true if the deprecated common label name exists, otherwise false.
//	err: error information if any error occurs during execution.

II. Does this pull request fix one issue?
fixes #5092
III. Special notes for reviews

…el.go

Signed-off-by: hongwangliu-nju <1649209217@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 12, 2025

Hi @hongwangliu-nju. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit bebe245 into fluid-cloudnative:master Jun 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to HasDeprecatedCommonLabelname in pkg/ddc/goosefs/deprecated_label.go.

2 participants