Skip to content

This PR is to add comments to newTestJindoEngine in pkg\ddc\jindo\delete_volume_test.go. #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 3 commits into from
Sep 15, 2025
+14 −0
Merged

This PR is to add comments to newTestJindoEngine in pkg\ddc\jindo\delete_volume_test.go. #5097

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef26dc3
Add comments to TestShouldCheckUFS in pkg/ddc/alluxio/ufs_test.go.
Zhangggggggggg Jun 12, 2025
ace6202
Add comments to newTestJindoEngine in pkg/ddc/jindo/delete_volume_tes…
Zhangggggggggg Jun 12, 2025
dc35b58
Update comments of function newTestJindoEngine
cheyang Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/ddc/jindo/delete_volume_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@ type TestCase struct {
isErr bool
}

// newTestJindoEngine creates a mock JindoEngine instance for testing purposes.
// This helper function is used to simulate JindoEngine behavior under different runtime conditions.
// It accepts a Kubernetes client, a runtime name and namespace, and a boolean flag indicating whether
// to initialize the engine with a runtime.
//
// Parameters:
// - client: a fake or real Kubernetes client used by the engine to interact with cluster resources.
// - name: the name of the JindoRuntime, used to build runtime metadata.
// - namespace: the namespace of the JindoRuntime.
// - withRunTime: if true, the engine will be initialized with a valid JindoRuntime and runtimeInfo;
// if false, the runtime and runtimeInfo will be set to nil, simulating a missing runtime.
//
// Returns:
// - A pointer to the initialized JindoEngine instance, ready for use in unit tests.
func newTestJindoEngine(client client.Client, name string, namespace string, withRunTime bool) *JindoEngine {
runTime := &datav1alpha1.JindoRuntime{}
runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JindoRuntime)
Expand Down