Skip to content

This PR is to add comments to TestTransformResourcesForMaster in pkg/ddc/alluxio/transform_resources_test.go. #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WUPEIhello wants to merge 1 commit into from
Closed

This PR is to add comments to TestTransformResourcesForMaster in pkg/ddc/alluxio/transform_resources_test.go. #5130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/ddc/alluxio/transform_resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,16 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
)

// TestTransformResourcesForMaster tests the transformResourcesForMaster method of the AlluxioEngine.
// This unit test verifies the resource transformation logic for the Alluxio master component.
// It ensures that the CPU and memory resource requests and limits from an AlluxioRuntime
// object are correctly passed and mapped to the Alluxio struct's Master and JobMaster fields.
// The test defines multiple scenarios using table-driven tests:
// 1. With both resource requests and limits set.
// 2. With only resource requests set.
// 3. With empty resource requirements or only empty requests/limits.
// For each test case, the transformResourcesForMaster method is invoked, and the output is
// compared against the expected result using DeepEqual. Any mismatch is reported as a test error.
func TestTransformResourcesForMaster(t *testing.T) {
testCases := map[string]struct {
runtime *datav1alpha1.AlluxioRuntime
Expand Down
Loading