Skip to content

import self-maintainerd ddc-helm in dockerfile#5163

Closed
Syspretor wants to merge 1 commit intofluid-cloudnative:masterfrom
Syspretor:feature/import-self-maintained-helm-repo
Closed

import self-maintainerd ddc-helm in dockerfile#5163
Syspretor wants to merge 1 commit intofluid-cloudnative:masterfrom
Syspretor:feature/import-self-maintained-helm-repo

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

In Fluid, there is only a unique version of runtime when deploying through Helm. Therefore, this PR import self-maintainerd ddc-helm and optimize the logic for confirming the version by listing release configmaps during helm install/uninstall to use the get method to retrieve version 1. This reduces the pressure of list operations on the apiserver.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: 玖宇 <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the feature/import-self-maintained-helm-repo branch from 9ed3d2f to 798285f Compare July 1, 2025 13:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 1, 2025

cp bin/alluxioruntime-controller /go/bin/alluxioruntime-controller

WORKDIR /go/src/github.com/fluid-cloudnative/
RUN git clone https://github.com/fluid-cloudnative/helm.git
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use git clone -b release-3.17-for-fluid instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm in branch release-3.17-for-fluid is using go 1.24.0 in the go.mod file. Is that ok we build helm in a golang 1.23.10 environment?

@Syspretor Syspretor closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants