Skip to content

PreferNodesWithoutCache mutate tests #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r0hansaxena wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PreferNodesWithoutCache mutate tests #5768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions pkg/webhook/plugins/prefernodeswithoutcache/prefer_nodes_without_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ var _ = Describe("PreferNodesWithoutCache Plugin", func() {
}
})

It("should create plugin and mutate pod correctly", func() {
It("should return early and keep pod unchanged when runtimeInfos is not empty", func() {
plugin, err := NewPlugin(cl, "")
Expect(err).NotTo(HaveOccurred())
Expect(plugin.GetName()).To(Equal(Name))
Expand All @@ -102,12 +102,32 @@ var _ = Describe("PreferNodesWithoutCache Plugin", func() {
shouldStop, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"test": runtimeInfo})
Expect(err).NotTo(HaveOccurred())
Expect(shouldStop).To(BeTrue())
Expect(pod.Spec.Affinity).To(BeNil())
})

It("should inject preferred scheduling term when runtimeInfos is empty", func() {
plugin, err := NewPlugin(cl, "")
Expect(err).NotTo(HaveOccurred())

shouldStop, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{})
Expect(err).NotTo(HaveOccurred())
Expect(shouldStop).To(BeTrue())
Expect(pod.Spec.Affinity).NotTo(BeNil())
Expect(pod.Spec.Affinity.NodeAffinity).NotTo(BeNil())
Expect(pod.Spec.Affinity.NodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution).To(HaveLen(1))
Expect(pod.Spec.Affinity.NodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution[0]).To(
Equal(getPreferredSchedulingTermForPodWithoutCache()),
)
})

_, err = plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{})
It("should handle nil runtime info entries without error", func() {
plugin, err := NewPlugin(cl, "")
Expect(err).NotTo(HaveOccurred())

_, err = plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"test": nil})
shouldStop, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"test": nil})
Expect(err).NotTo(HaveOccurred())
Expect(shouldStop).To(BeTrue())
Comment thread
r0hansaxena marked this conversation as resolved.
Expect(pod.Spec.Affinity).To(BeNil())
})
})
})
Loading