chore(runtime): apply gofmt to runtime package#5792
chore(runtime): apply gofmt to runtime package#5792fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
Conversation
…entation - Deleted the unfinished GetRuntimeStatus function which retrieved runtime status by type, name, and namespace - Cleaned up unused code and comments related to runtime status retrieval - Retained and organized existing RuntimeInfo interface and related helper functions for runtime info construction - Ensured the code only includes fully implemented and functional parts to improve maintainability Signed-off-by: cheyang <cheyang.cy@alibaba-inc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request includes minor formatting and documentation updates to the WithClientMetrics function in pkg/ddc/base/runtime.go. However, the reviewer pointed out that the changes do not reflect the pull request's stated goal of removing the GetRuntimeStatus function and cleaning up unused code, which remain in the file.
| func (info *RuntimeInfo) GetAnnotations() map[string]string { | ||
| return info.annotations | ||
| } | ||
|
|
There was a problem hiding this comment.
The pull request title and description state that the GetRuntimeStatus function is being removed and unused code is being cleaned up. However, the provided changes only include minor documentation and formatting updates. The GetRuntimeStatus function (starting at line 614) and its associated comments are still present in the file. Please ensure that the intended refactoring and deletions are included in the commit.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5792 +/- ##
=======================================
Coverage 58.46% 58.46%
=======================================
Files 473 473
Lines 32222 32222
=======================================
Hits 18839 18839
Misses 11836 11836
Partials 1547 1547 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongGu
changed the title
cheyang
changed the title
|
/gemini review |
1 similar comment
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request performs minor formatting improvements in pkg/ddc/base/runtime.go, including adding a newline for better separation between functions and correcting indentation and trailing whitespace in the documentation comments for WithClientMetrics. I have no feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request performs minor formatting and documentation cleanup in pkg/ddc/base/runtime.go, including adding a newline for better function separation, removing trailing whitespace, and adjusting indentation in the Go doc comments for consistency. No review comments were provided, and I have no further feedback to provide.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RongGu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fluid-e2e-bot
Bot
merged commit d6e3cc5
into
fluid-cloudnative:master
2 participants
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews