Skip to content

chore(runtime): apply gofmt to runtime package #5792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 1 commit into from
Apr 17, 2026
Merged

chore(runtime): apply gofmt to runtime package #5792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/ddc/base/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,16 +235,17 @@ func WithAnnotations(annotations map[string]string) RuntimeInfoOption {
func (info *RuntimeInfo) GetAnnotations() map[string]string {
return info.annotations
}

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request title and description state that the GetRuntimeStatus function is being removed and unused code is being cleaned up. However, the provided changes only include minor documentation and formatting updates. The GetRuntimeStatus function (starting at line 614) and its associated comments are still present in the file. Please ensure that the intended refactoring and deletions are included in the commit.

// WithClientMetrics sets the client metrics for the RuntimeInfo.
// This function returns a RuntimeInfoOption that configures how client metrics
// are collected, including setting a default scrape target if none is provided
// This function returns a RuntimeInfoOption that configures how client metrics
// are collected, including setting a default scrape target if none is provided
// and parsing the scrape target string into a valid selector.
//
// Parameters:
// - clientMetrics (datav1alpha1.ClientMetrics): The client metrics configuration to be applied.
// - clientMetrics (datav1alpha1.ClientMetrics): The client metrics configuration to be applied.
//
// Returns:
// - (RuntimeInfoOption): A function that updates the RuntimeInfo with the specified metrics configuration.
// - (RuntimeInfoOption): A function that updates the RuntimeInfo with the specified metrics configuration.
func WithClientMetrics(clientMetrics datav1alpha1.ClientMetrics) RuntimeInfoOption {
return func(info *RuntimeInfo) error {
if len(clientMetrics.ScrapeTarget) == 0 {
Expand Down
Loading