Skip to content

This PR is to add comments to convertToTieredstoreInfo in pkg/ddc/base/runtime.go.#6054

Open
Butteredryetoast wants to merge 1 commit into
fluid-cloudnative:masterfrom
Butteredryetoast:add-comments-to-convert-to-tieredstore-info
Open

This PR is to add comments to convertToTieredstoreInfo in pkg/ddc/base/runtime.go.#6054
Butteredryetoast wants to merge 1 commit into
fluid-cloudnative:masterfrom
Butteredryetoast:add-comments-to-convert-to-tieredstore-info

Conversation

@Butteredryetoast

Copy link
Copy Markdown

Ⅰ. Describe what this PR does
Add comments to convertToTieredstoreInfo in pkg/ddc/base/runtime.go.

Ⅱ. Does this pull request fix one issue?
fixes #6053

Ⅲ. Special notes for reviews
None.

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Hi @Butteredryetoast. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a descriptive comment to the convertToTieredstoreInfo function in pkg/ddc/base/runtime.go to explain its purpose, normalization of cache paths, and quota settings. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.86%. Comparing base (94f3b6c) to head (bd4debb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6054   +/-   ##
=======================================
  Coverage   64.86%   64.86%           
=======================================
  Files         480      480           
  Lines       33514    33514           
=======================================
  Hits        21738    21738           
  Misses      10051    10051           
  Partials     1725     1725           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: 郑永祺 <yongqizheng992@gmail.com>
@Butteredryetoast Butteredryetoast force-pushed the add-comments-to-convert-to-tieredstore-info branch from bd4debb to 19085b7 Compare June 23, 2026 12:02
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to convertToTieredstoreInfo in pkg/ddc/base/runtime.go.

1 participant