fix(rollback): errors.Is instead of string comp

hiddeco · scottrigby · commit 4a19a5b6fb91 · 2026-01-14T18:50:50.000-05:00
Signed-off-by: Hidde Beydals <hidde@hhh.computer> (cherry picked from commit d158708) (cherry picked from commit 0cd9a60)
diff --git a/pkg/action/rollback.go b/pkg/action/rollback.go
@@ -26,6 +26,7 @@ import (
 
 	"helm.sh/helm/v3/pkg/chartutil"
 	"helm.sh/helm/v3/pkg/release"
+	"helm.sh/helm/v3/pkg/storage/driver"
 	helmtime "helm.sh/helm/v3/pkg/time"
 )
 
@@ -249,7 +250,7 @@ func (r *Rollback) performRollback(currentRelease, targetRelease *release.Releas
 	}
 
 	deployed, err := r.cfg.Releases.DeployedAll(currentRelease.Name)
-	if err != nil && !strings.Contains(err.Error(), "has no deployed releases") {
+	if err != nil && !errors.Is(err, driver.ErrNoDeployedReleases) {
 		return nil, err
 	}
 	// Supersede all previous deployments, see issue #2941.

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ import (`
`26`	`26`
`27`	`27`	`"helm.sh/helm/v3/pkg/chartutil"`
`28`	`28`	`"helm.sh/helm/v3/pkg/release"`
	`29`	`+ "helm.sh/helm/v3/pkg/storage/driver"`
`29`	`30`	`helmtime "helm.sh/helm/v3/pkg/time"`
`30`	`31`	`)`
`31`	`32`
`@@ -249,7 +250,7 @@ func (r Rollback) performRollback(currentRelease, targetRelease release.Releas`
`249`	`250`	`}`
`250`	`251`
`251`	`252`	`deployed, err := r.cfg.Releases.DeployedAll(currentRelease.Name)`
`252`		`- if err != nil && !strings.Contains(err.Error(), "has no deployed releases") {`
	`253`	`+ if err != nil && !errors.Is(err, driver.ErrNoDeployedReleases) {`
`253`	`254`	`return nil, err`
`254`	`255`	`}`
`255`	`256`	`// Supersede all previous deployments, see issue #2941.`