Commit b441fec
committed
fix(afc): Address PR review comments in
- Add `rel="noopener noreferrer"` to external Spoolman link to prevent
reverse-tabnabbing via `target="_blank"`
- Keep `!this.spoolId` guard in `spoolUrl` — spool ID `0` is invalid in
Spoolman so the falsy check is correct and consistent with `spool` getter
- Replace hard-coded English strings in tooltip with i18n keys
(`app.afc.WeightRemaining`, `app.afc.WeightUsed`); fix `spoolUsedWeight`
guard from truthy to `!= null` so `0 g used` is displayed correctly
Signed-off-by: paxx12 <245230251+paxx12@users.noreply.github.com>AfcCardUnitLaneBody
1 parent fbed6a9 commit b441fec
2 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| 109 | + | |
109 | 110 | | |
110 | 111 | | |
111 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
90 | 91 | | |
| 92 | + | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| |||
0 commit comments