refactor: enforce printer state immutability (#1874)

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: pedrolamas

src/store/printer/actions.ts

@@ -168,19 +168,19 @@ export const actions = {
    */
 
   /**
-   * Stores the printers object list.
+   * Builds the subscription map from the printer object list and subscribes to updates.
    */
-  async onPrinterObjectsList ({ commit }, payload: Moonraker.KlippyApis.ObjectsListResponse) {
+  async onPrinterObjectsList (_, payload: Moonraker.KlippyApis.ObjectsListResponse) {
     // Given our object list, subscribe to any data we'd want constant updates for
     // and prepopulate our store.
     const subscriptions: Record<string, null> = {}
 
     for (const key of payload.objects) {
-      if (!key.includes('menu')) {
-        subscriptions[key] = null
+      if (key === 'menu' || key.startsWith('menu ')) {
+        continue
       }
 
-      commit('setPrinterObjectList', key.replace(' ', '.'))
+      subscriptions[key] = null
     }
 
     SocketActions.printerObjectsSubscribe(subscriptions)

src/store/printer/mutations.ts

@@ -28,37 +28,29 @@ export const mutations = {
   },
 
   setPrinterInfo (state, payload: Moonraker.KlippyApis.Info) {
-    state.info = payload
-  },
-
-  setPrinterObjectList (state, payload) {
-    if (!state.printer.objects.includes(payload)) {
-      state.printer.objects.push(payload)
-    }
+    state.info = Object.freeze(payload)
   },
 
   setClearEndStops (state) {
-    if (state.printer.query_endstops == null) {
+    const queryEndstops = state.printer.query_endstops
+
+    if (queryEndstops == null) {
       return
     }
 
-    state.printer.query_endstops = {
-      ...state.printer.query_endstops,
-      last_query: {}
-    }
+    queryEndstops.last_query = Object.freeze({})
   },
 
   setClearScrewsTiltAdjust (state) {
-    if (state.printer.screws_tilt_adjust == null) {
+    const screwsTiltAdjust = state.printer.screws_tilt_adjust
+
+    if (screwsTiltAdjust == null) {
       return
     }
 
-    state.printer.screws_tilt_adjust = {
-      ...state.printer.screws_tilt_adjust,
-      error: false,
-      max_deviation: null,
-      results: {}
-    }
+    screwsTiltAdjust.error = false
+    screwsTiltAdjust.max_deviation = null
+    screwsTiltAdjust.results = Object.freeze({})
   },
 
   setSocketNotify<T extends keyof Klipper.PrinterState> (state: PrinterState, payload: { key: T, payload: Klipper.PrinterState[T] }) {

src/store/printer/state.ts

@@ -19,7 +19,6 @@ export const defaultState = (): PrinterState => {
         config: {},
         settings: {}
       },
-      objects: [],
       idle_timeout: {
         state: 'Idle',
         printing_time: 0

src/typings/klipper.d.ts

@@ -14,8 +14,6 @@ declare namespace Klipper {
     {
       // These keys are always available
 
-      objects: string[];
-
       configfile: ConfigFileState;
 
       gcode_move: GcodeMoveState;