fix(timelapse): parse timelapse status consistently#1829
Merged
Conversation
Signed-off-by: Mathis Mensing <github@matmen.dev>
pedrolamas
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Timelapse Status widget’s frame counter resetting on newframe websocket events by ensuring the timelapse store always receives/derives data using the same shape as Moonraker’s LastFrameInfoResponse.
Changes:
- Update
timelapse/onEventhandling fornewframeto commit{ framecount, lastframefile }(matching Moonraker’sLastFrameInfoResponse) instead of{ count, uniqueCount, file }. - Make
getLastFrame.uniqueCountderive consistently fromframecount(with a fallback to parsing the frame number fromlastframefile).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/store/timelapse/actions.ts | Fix newframe event handling to commit the correct LastFrameInfoResponse shape so state updates don’t wipe the counter. |
| src/store/timelapse/getters.ts | Compute uniqueCount from framecount (fallback to filename parsing) while mapping lastframefile → file for UI consumption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1820