refactor(GcodePreview): auto-zoom without cropping#1867
Merged
pedrolamas merged 3 commits intoJun 3, 2026
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the G-code preview widget’s auto-zoom behavior so the SVG viewBox always includes the bed, and auto-zoom is performed via pan/zoom transforms (instead of shrinking the viewBox and potentially clipping the bed).
Changes:
- Trigger auto-zoom when enabling the setting and when auto-zoom dependencies change (
bounds,flipX,flipY). - Remove
autoZoom-drivenviewBoxshrinking; keepviewBoxbed-inclusive at all times. - Add
zoomToBounds()to compute a pan/zoom transform that centers and fits the print bounds.
Move auto-zoom side-effects out of the computed setter and into a
`@Watch('autoZoom')` handler so the preview fits/resets consistently
whether the setting changes locally or syncs from the server.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
`viewBox` (and thus `zoomToBounds()`) depends on `bedSize`, but the re-fit watcher didn't track it. When bed limits arrive after connect or change on a printer switch, the applied pan/zoom transform went stale. Add `bedSize` as an auto-zoom dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform auto-zoom to print content without cropping the bed.