fix(Thermals): sensor sort order anomalies#1868
Merged
pedrolamas merged 2 commits intoJun 4, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts how temperature-related sensors are collected and ordered in the printer store to address Thermals panel ordering anomalies (reported in #1866), and simplifies getChartableSensors key matching by replacing type-name RegExp matching with predicate functions.
Changes:
- Reworks
printer/getSensorsto build sensors in type-based groups and sort by name within each group. - Reworks
printer/getChartableSensorsto usestartsWith-based predicates instead of per-group RegExp matching. - Updates chartable sensor key filtering/sorting to align with the new grouping approach.
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect sensor ordering in the Thermals panel that manifested with larger numbers of temperature sensors (e.g. "Carto PCB" appearing before "Carto MCU").
Sensors are now grouped by type and sorted alphabetically by name within each group.
Also replaces the RegExp-based key matching in
getChartableSensorswith predicate functions, which are cleaner and avoid per-key regex compilation.Mitigates the sensor sort order issues reported in #1866.