refactor: enforce printer state immutability#1874
Merged
pedrolamas merged 3 commits intoJun 10, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
added
the
Code - Optimizations
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the printer Vuex module state handling to reduce in-place mutation and improve reactivity characteristics, primarily by removing the stored printer object list and introducing Object.freeze() for some stored payloads.
Changes:
- Removed
printer.objectsfrom Klipper typings and the printer store default state. - Simplified
onPrinterObjectsListto only build the subscription map (and refined menu object filtering). - Began freezing certain stored printer payloads (
info, and some “clear/reset” mutations).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/typings/klipper.d.ts | Removes objects from the typed Klipper printer state surface. |
| src/store/printer/state.ts | Drops printer.objects from the default printer store state. |
| src/store/printer/mutations.ts | Removes object-list mutation; adds Object.freeze() in several mutations. |
| src/store/printer/actions.ts | Stops committing printer object list; builds subscriptions directly and adjusts menu filtering. |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor printer state to improve immutability, which leads to better reactivity performance.