fix: add rel=noopener to target=_blank links#1880
Merged
pedrolamas merged 1 commit intoJun 16, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds rel="noopener noreferrer" wherever the app opens links in a new tab/window (target="_blank"), mitigating reverse-tabnabbing and preventing access to window.opener.
Changes:
- Adds
rel="noopener noreferrer"to various<a>,<app-btn>, and<v-btn>links usingtarget="_blank". - Ensures Markdown preview links rendered via
markedalso includerel="noopener noreferrer". - Documents the
target="_blank"+rel="noopener noreferrer"requirement inAGENTS.md.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/widgets/spoolman/SpoolSelectionDialog.vue | Adds rel="noopener noreferrer" to the Spoolman manage link opened in a new tab. |
| src/components/widgets/filesystem/FilePreviewDialog.vue | Updates Markdown link rendering to include rel="noopener noreferrer" alongside target="_blank". |
| src/components/widgets/filesystem/FileEditorDialog.vue | Adds rel="noopener noreferrer" to the external config map link. |
| src/components/widgets/camera/CameraItem.vue | Adds rel="noopener noreferrer" to the raw camera URL link opened in a new tab. |
| src/components/widgets/afc/dialogs/AfcSettingsDialog.vue | Adds rel="noopener noreferrer" to the external AFC help link. |
| src/components/settings/VersionSettings.vue | Adds rel="noopener noreferrer" to remote URL links opened in a new tab. |
| src/components/settings/VersionInformationDialog.vue | Adds rel="noopener noreferrer" to commit/branch links opened in a new tab. |
| src/components/layout/AppNotificationMenu.vue | Adds rel="noopener noreferrer" to notification action links opened in a new tab. |
| src/components/common/Login.vue | Adds rel="noopener noreferrer" to docs links opened in a new tab. |
| AGENTS.md | Documents the project convention requiring rel="noopener noreferrer" with target="_blank". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
rel="noopener noreferrer"to alltarget="_blank"links across the app, preventing reverse-tabnabbing and blocking new tabs from accessingwindow.opener.Follow-up to the same fix made for
linkExternalUrlsin #1879