refactor: typing improvements#1894
Merged
pedrolamas merged 1 commit intoJun 28, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
added
the
Code - Optimizations
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors several Vuex store state shapes to strengthen TypeScript immutability guarantees and reduce Vue 2 reactivity overhead by freezing data received from Moonraker/Spoolman, aligning with Fluidd’s pattern of treating socket payloads as immutable snapshots.
Changes:
- Tighten Spoolman typings (e.g.,
multi_color_directionas a string-literal union). - Make multiple store state collections/objects readonly and freeze assigned payloads to avoid unnecessary deep reactivity.
- Propagate readonly typing to a filesystem widget getter consuming
files/getRootFiles.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/typings/moonraker.spoolman.d.ts | Adds a constrained union type for filament multi-color direction. |
| src/store/spoolman/types.ts | Marks info and spools state as readonly to reflect immutability. |
| src/store/spoolman/mutations.ts | Freezes spools/info payloads on assignment. |
| src/store/jobQueue/types.ts | Marks queuedJobs as a readonly array. |
| src/store/jobQueue/mutations.ts | Freezes queued job arrays when committing to state. |
| src/store/history/types.ts | Makes history job elements readonly at the type level. |
| src/store/history/mutations.ts | Freezes history job objects when storing/updating them. |
| src/store/files/types.ts | Applies readonly typing to roots, disk usage, root files, and directory entries. |
| src/store/files/mutations.ts | Freezes file/dir/diskUsage entries and root arrays to limit reactivity churn. |
| src/store/console/types.ts | Makes console entries and gcodeHelp readonly at the type level. |
| src/store/console/mutations.ts | Freezes gcodeHelp payload on assignment. |
| src/components/widgets/filesystem/FileSystemGoToFileDialog.vue | Updates rootFiles getter typing to readonly to match store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to improve some types and freeze to ignore reactivity and improve performance