Skip to content

style: new emergency stop icon#1897

Merged
pedrolamas merged 3 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/estop-style
Jul 3, 2026
Merged

style: new emergency stop icon#1897
pedrolamas merged 3 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/estop-style

Conversation

@pedrolamas

Copy link
Copy Markdown
Member

Following up on #1465, this PR is to replace the Emergency Stop icon with something more recognizable like the CNC emergency stop button.

Wide screen

image image

Compact screen

image image

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas requested a review from Copilot July 1, 2026 14:12
@pedrolamas pedrolamas added the UI - Change All matters related to a significant change in the UI label Jul 1, 2026
@pedrolamas pedrolamas added this to the 1.37.3 milestone Jul 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Emergency Stop (E-Stop) visual treatment in the Fluidd UI (icons defined in src/globals.ts and used by layout components) to be more recognizable, aligning with the discussion-linked goal of improving E-Stop discoverability.

Changes:

  • Replace the $estop icon mapping with a new custom mdiEmergencyStop SVG path in src/globals.ts.
  • Update the AppBar E-Stop button styling to a red (error) rounded button with a white icon.
  • Adjust the mobile E-Stop FAB sizing in App.vue (note: App.vue also includes unrelated theme/title/debug changes that should be split/reverted).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
src/globals.ts Swaps the $estop icon mapping to a new emergency-stop SVG path.
src/components/layout/AppBar.vue Updates E-Stop button color/shape and icon color for better visibility.
src/App.vue Tweaks mobile E-Stop FAB size, but also adds unrelated theme/title/debug logic (needs cleanup/splitting).

Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread src/components/layout/AppBar.vue
Comment thread src/App.vue
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@pedrolamas pedrolamas merged commit a4cebec into fluidd-core:develop Jul 3, 2026
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/estop-style branch July 3, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI - Change All matters related to a significant change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants