style: new emergency stop icon#1897
Merged
pedrolamas merged 3 commits intoJul 3, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Emergency Stop (E-Stop) visual treatment in the Fluidd UI (icons defined in src/globals.ts and used by layout components) to be more recognizable, aligning with the discussion-linked goal of improving E-Stop discoverability.
Changes:
- Replace the
$estopicon mapping with a new custommdiEmergencyStopSVG path insrc/globals.ts. - Update the AppBar E-Stop button styling to a red (error) rounded button with a white icon.
- Adjust the mobile E-Stop FAB sizing in
App.vue(note:App.vuealso includes unrelated theme/title/debug changes that should be split/reverted).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/globals.ts | Swaps the $estop icon mapping to a new emergency-stop SVG path. |
| src/components/layout/AppBar.vue | Updates E-Stop button color/shape and icon color for better visibility. |
| src/App.vue | Tweaks mobile E-Stop FAB size, but also adds unrelated theme/title/debug logic (needs cleanup/splitting). |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #1465, this PR is to replace the Emergency Stop icon with something more recognizable like the CNC emergency stop button.
Wide screen
Compact screen