feat: add retract and extrude indicator#1898
Open
pedrolamas wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an extruding/retracting indicator to the Toolhead widget header using Klipper’s motion_report.live_extruder_velocity, and aligns related UI affordances (icons/tooltips) to match.
Changes:
- Add a header icon + tooltip in
ToolheadCardthat reflects live extruder movement direction (extruding vs retracting). - Update extrude/retract button icons and adjust global icon aliases for
retract/extrude. - Add English i18n strings for “Extruding” / “Retracting”.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/locales/en.yaml | Adds new tooltip strings for the extruding/retracting indicator. |
| src/globals.ts | Introduces new MDI imports and maps retract / extrude icon aliases to triangle icons. |
| src/components/widgets/toolhead/ToolheadCard.vue | Adds live extruder velocity-derived direction indicator (icon + tooltip) in the card header. |
| src/components/widgets/toolhead/ExtruderMoves.vue | Switches extrude/retract button icons to the new aliases. |
| src/components/widgets/retract/RetractCard.vue | Uses $retractions icon alias for the Retract card to preserve the prior card icon after alias changes. |
| <v-icon | ||
| v-bind="attrs" | ||
| class="ml-3" | ||
| :color="extruderMovementDirection < 0 ? 'red' : 'green'" |
Contributor
|
oh, im sorry to say, but this looks very web 1.0. making it much smaller, and using greyscale up/down icons from the set you're using is the way to go I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new extruding/retracting indicator to the header of the Tool card, using the live extruder velocity.
Extruding
Retracting