fix add icon/text allow overlap (#303)

Author: andrea689

lib/src/controller.dart

@@ -371,34 +371,6 @@ class MapboxMapController extends ChangeNotifier {
     _symbols.remove(id);
   }
 
-  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
-  Future<void> setSymbolIconAllowOverlap(bool enable) async {
-    await _channel.invokeMethod('symbolManager#iconAllowOverlap', <String, dynamic>{
-      'iconAllowOverlap': enable,
-    });
-  }
-  
-  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
-  Future<void> setSymbolIconIgnorePlacement(bool enable) async {
-    await _channel.invokeMethod('symbolManager#iconIgnorePlacement', <String, dynamic>{
-      'iconIgnorePlacement': enable,
-    });
-  }
-  
-  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
-  Future<void> setSymbolTextAllowOverlap(bool enable) async {
-    await _channel.invokeMethod('symbolManager#textAllowOverlap', <String, dynamic>{
-      'textAllowOverlap': enable,
-    });
-  }
-
-  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
-  Future<void> setSymbolTextIgnorePlacement(bool enable) async {
-    await _channel.invokeMethod('symbolManager#textIgnorePlacement', <String, dynamic>{
-      'textIgnorePlacement': enable,
-    });
-  }
-
   /// Adds a line to the map, configured using the specified custom [options].
   ///
   /// Change listeners are notified once the line has been added on the
@@ -620,4 +592,24 @@ class MapboxMapController extends ChangeNotifier {
   Future<void> addImage(String name, Uint8List bytes, [bool sdf = false]) {
     return MapboxGlPlatform.instance.addImage(name, bytes, sdf);
   }
+
+  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
+  Future<void> setSymbolIconAllowOverlap(bool enable) async {
+    await MapboxGlPlatform.instance.setSymbolIconAllowOverlap(enable);
+  }
+
+  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
+  Future<void> setSymbolIconIgnorePlacement(bool enable) async {
+    await MapboxGlPlatform.instance.setSymbolIconIgnorePlacement(enable);
+  }
+
+  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
+  Future<void> setSymbolTextAllowOverlap(bool enable) async {
+    await MapboxGlPlatform.instance.setSymbolTextAllowOverlap(enable);
+  }
+
+  /// For more information on what this does, see https://docs.mapbox.com/help/troubleshooting/optimize-map-label-placement/#label-collision
+  Future<void> setSymbolTextIgnorePlacement(bool enable) async {
+    await MapboxGlPlatform.instance.setSymbolTextIgnorePlacement(enable);
+  }
 }

mapbox_gl_platform_interface/lib/src/mapbox_gl_platform_interface.dart

@@ -176,4 +176,24 @@ abstract class MapboxGlPlatform {
       [bool sdf = false]) async {
     throw UnimplementedError('addImage() has not been implemented.');
   }
+
+  Future<void> setSymbolIconAllowOverlap(bool enable) async {
+    throw UnimplementedError(
+        'setSymbolIconAllowOverlap() has not been implemented.');
+  }
+
+  Future<void> setSymbolIconIgnorePlacement(bool enable) async {
+    throw UnimplementedError(
+        'setSymbolIconIgnorePlacement() has not been implemented.');
+  }
+
+  Future<void> setSymbolTextAllowOverlap(bool enable) async {
+    throw UnimplementedError(
+        'setSymbolTextAllowOverlap() has not been implemented.');
+  }
+
+  Future<void> setSymbolTextIgnorePlacement(bool enable) async {
+    throw UnimplementedError(
+        'setSymbolTextIgnorePlacement() has not been implemented.');
+  }
 }

mapbox_gl_platform_interface/lib/src/method_channel_mapbox_gl.dart

@@ -356,6 +356,7 @@ class MethodChannelMapboxGl extends MapboxGlPlatform {
     }
   }
 
+  @override
   Future<void> addImage(String name, Uint8List bytes,
       [bool sdf = false]) async {
     try {
@@ -369,4 +370,52 @@ class MethodChannelMapboxGl extends MapboxGlPlatform {
       return new Future.error(e);
     }
   }
+
+  @override
+  Future<void> setSymbolIconAllowOverlap(bool enable) async {
+    try {
+      await _channel
+          .invokeMethod('symbolManager#iconAllowOverlap', <String, dynamic>{
+        'iconAllowOverlap': enable,
+      });
+    } on PlatformException catch (e) {
+      return new Future.error(e);
+    }
+  }
+
+  @override
+  Future<void> setSymbolIconIgnorePlacement(bool enable) async {
+    try {
+      await _channel
+          .invokeMethod('symbolManager#iconIgnorePlacement', <String, dynamic>{
+        'iconIgnorePlacement': enable,
+      });
+    } on PlatformException catch (e) {
+      return new Future.error(e);
+    }
+  }
+
+  @override
+  Future<void> setSymbolTextAllowOverlap(bool enable) async {
+    try {
+      await _channel
+          .invokeMethod('symbolManager#textAllowOverlap', <String, dynamic>{
+        'textAllowOverlap': enable,
+      });
+    } on PlatformException catch (e) {
+      return new Future.error(e);
+    }
+  }
+
+  @override
+  Future<void> setSymbolTextIgnorePlacement(bool enable) async {
+    try {
+      await _channel
+          .invokeMethod('symbolManager#textIgnorePlacement', <String, dynamic>{
+        'textIgnorePlacement': enable,
+      });
+    } on PlatformException catch (e) {
+      return new Future.error(e);
+    }
+  }
 }

mapbox_gl_web/lib/src/mapbox_map_controller.dart

@@ -259,6 +259,7 @@ class MapboxMapController extends MapboxGlPlatform
     );
   }
 
+  @override
   Future<void> addImage(String name, Uint8List bytes,
       [bool sdf = false]) async {
     final photo = decodeImage(bytes);
@@ -275,6 +276,30 @@ class MapboxMapController extends MapboxGlPlatform
     }
   }
 
+  @override
+  Future<void> setSymbolIconAllowOverlap(bool enable) async {
+    //TODO: to implement
+    print('setSymbolIconAllowOverlap not implemented yet');
+  }
+
+  @override
+  Future<void> setSymbolIconIgnorePlacement(bool enable) async {
+    //TODO: to implement
+    print('setSymbolIconIgnorePlacement not implemented yet');
+  }
+
+  @override
+  Future<void> setSymbolTextAllowOverlap(bool enable) async {
+    //TODO: to implement
+    print('setSymbolTextAllowOverlap not implemented yet');
+  }
+
+  @override
+  Future<void> setSymbolTextIgnorePlacement(bool enable) async {
+    //TODO: to implement
+    print('setSymbolTextIgnorePlacement not implemented yet');
+  }
+
   CameraPosition _getCameraPosition() {
     if (_trackCameraPosition) {
       final center = _map.getCenter();