Skip to content

Commit e742309

Browse files
committed
fix: change commons MLKit product from BarcodeScanning to ObjectDetection with explanatory comment
1 parent c6ce105 commit e742309

14 files changed

Lines changed: 776 additions & 1 deletion

File tree

packages/google_mlkit_barcode_scanning/ios/google_mlkit_barcode_scanning/Package.resolved

Lines changed: 59 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google_mlkit_commons/ios/google_mlkit_commons/Package.swift

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,15 @@ let package = Package(
2222
.target(
2323
name: "google_mlkit_commons",
2424
dependencies: [
25-
.product(name: "MLKitBarcodeScanning", package: "google-mlkit-swiftpm")
25+
// google-mlkit-swiftpm does not expose standalone MLKitVision or MLKitCommon
26+
// library products — they are only available as binary targets bundled inside
27+
// composite products (e.g. MLKitBarcodeScanning, MLKitFaceDetection, etc.).
28+
// All vision-family products include MLKitVision + MLKitCommon (via the Common
29+
// target), so we must pick one even though Commons itself does not use the
30+
// specific module. MLKitObjectDetection is used here as a generic choice; the
31+
// unused xcframework has no material impact because any real app using Google
32+
// ML Kit will depend on at least one vision plugin that already brings it in.
33+
.product(name: "MLKitObjectDetection", package: "google-mlkit-swiftpm")
2634
],
2735
path: "Sources/google_mlkit_commons"
2836
)

packages/google_mlkit_digital_ink_recognition/ios/google_mlkit_digital_ink_recognition/Package.resolved

Lines changed: 59 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google_mlkit_entity_extraction/ios/google_mlkit_entity_extraction/Package.resolved

Lines changed: 59 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google_mlkit_face_detection/ios/google_mlkit_face_detection/Package.resolved

Lines changed: 59 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google_mlkit_face_mesh_detection/ios/google_mlkit_face_mesh_detection/Package.resolved

Lines changed: 59 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google_mlkit_image_labeling/ios/google_mlkit_image_labeling/Package.resolved

Lines changed: 59 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)