Skip to content

perf: Migrate Java to Kotlin #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbernaly merged 6 commits into from
Feb 17, 2026
Merged

perf: Migrate Java to Kotlin #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8f7ad9
perf: use pigeon for code gen
bensonarafat Feb 9, 2026
670c5b2
Update the common package
bensonarafat Feb 10, 2026
23cebc5
pref: Remove pigeon changes and keep kotlin migration
bensonarafat Feb 11, 2026
f35eb55
fix: calling the static method from mlkit_common
bensonarafat Feb 11, 2026
84e87de
Remove translation changes
bensonarafat Feb 11, 2026
97b06c5
fix: code indetent
bensonarafat Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/example/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,10 @@ packages:
dependency: transitive
description:
name: meta
sha256: e3641ec5d63ebf0d9b41bd43201a66e3fc79a65db5f61fc181f04cd27aab950c
sha256: "23f08335362185a5ea2ad3a4e597f1375e78bce8a040df5c600c8d3552ef2394"
url: "https://pub.dev"
source: hosted
version: "1.16.0"
version: "1.17.0"
mime:
dependency: transitive
description:
Expand Down Expand Up @@ -611,10 +611,10 @@ packages:
dependency: transitive
description:
name: test_api
sha256: "522f00f556e73044315fa4585ec3270f1808a4b186c936e612cab0b565ff1e00"
sha256: ab2726c1a94d3176a45960b6234466ec367179b87dd74f1611adb1f3b5fb9d55
url: "https://pub.dev"
source: hosted
version: "0.7.6"
version: "0.7.7"
typed_data:
dependency: transitive
description:
Expand Down
11 changes: 11 additions & 0 deletions packages/google_mlkit_commons/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ group = "com.google_mlkit_commons"
version = "1.0"

buildscript {
ext.kotlin_version = "2.2.20"
repositories {
google()
mavenCentral()
}

dependencies {
classpath("com.android.tools.build:gradle:8.13.0")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.2.0")
}
}

Expand All @@ -20,6 +22,7 @@ rootProject.allprojects {
}

apply plugin: "com.android.library"
apply plugin: "kotlin-android"

android {
namespace = "com.google_mlkit_commons"
Expand All @@ -30,6 +33,14 @@ android {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}

kotlinOptions {
jvmTarget = '11'
}

sourceSets {
main.java.srcDirs += "src/main/kotlin"
}

defaultConfig {
minSdk = 21
Expand Down
7 changes: 7 additions & 0 deletions packages/google_mlkit_commons/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.0-milestone-1-bin.zip

Copilot AI Feb 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gradle-wrapper.properties file specifies Gradle version 9.0-milestone-1, which is a pre-release milestone version. Using milestone (pre-release) versions in production code can introduce instability and potential compatibility issues. Consider using a stable release version of Gradle instead, such as 8.x or waiting for the stable 9.0 release.

Suggested change
distributionUrl=https\://services.gradle.org/distributions/gradle-9.0-milestone-1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip

Copilot uses AI. Check for mistakes.
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
118 changes: 0 additions & 118 deletions ...gle_mlkit_commons/android/src/main/java/com/google_mlkit_commons/GenericModelManager.java
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions ...lkit_commons/android/src/main/java/com/google_mlkit_commons/GoogleMlKitCommonsPlugin.java
View file
Open in desktop

This file was deleted.

136 changes: 0 additions & 136 deletions ...gle_mlkit_commons/android/src/main/java/com/google_mlkit_commons/InputImageConverter.java
View file
Open in desktop

This file was deleted.

Loading