Skip to content

Add FlutterFramework SwiftPM dep#2420

Open
alejandro-all-win-software wants to merge 1 commit into
flutter-stripe:mainfrom
alejandro-all-win-software:task/stripe-ios-spm-flutterframework
Open

Add FlutterFramework SwiftPM dep#2420
alejandro-all-win-software wants to merge 1 commit into
flutter-stripe:mainfrom
alejandro-all-win-software:task/stripe-ios-spm-flutterframework

Conversation

@alejandro-all-win-software
Copy link
Copy Markdown
Contributor

@alejandro-all-win-software alejandro-all-win-software commented May 21, 2026

DESCRIPTION

  • There's a new section into the migration guide. Now, adding FlutterFramework dependency is required to avoid a new warning.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Do all checks pass?
  • Have you developed the feature on the latest stable version of Flutter?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Summary by CodeRabbit

  • Chores
    • Updated package dependencies and build configuration to incorporate local framework integration for the iOS Stripe module.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 653bcb72-0923-4041-a5b3-ad1494a27e0a

📥 Commits

Reviewing files that changed from the base of the PR and between 8b8d0eb and 529995a.

📒 Files selected for processing (1)
  • packages/stripe_ios/ios/stripe_ios/Package.swift

📝 Walkthrough

Walkthrough

This PR updates the Swift Package Manager configuration for the stripe_ios package to add and wire a local FlutterFramework SPM dependency. The Package.swift file now declares FlutterFramework as a local package dependency and includes it in the stripe_ios target's dependency list.

Changes

FlutterFramework SPM dependency

Layer / File(s) Summary
FlutterFramework SPM package declaration and target wiring
packages/stripe_ios/ios/stripe_ios/Package.swift
Package dependencies now include a local FlutterFramework package reference via path-based dependency, and the stripe_ios target's dependencies are updated to include the FlutterFramework product from that package.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A local package hops into place,
FlutterFramework joins the SPM space,
Two lines of wiring, clean and bright,
Dependencies linked, the path feels right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: adding a FlutterFramework Swift Package Manager dependency to the stripe_ios package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant