Remove FlutterView (NUI/Dali embedding) support

FlutterView rendered Flutter into a NUI/Dali ImageView via
FlutterDesktopViewCreateFromImageView. It depends on dali2-adaptor /
dali2-core and keeps breaking against new Tizen platform versions,
adding instability for little real usage. Drop the feature.

- Delete flutter_tizen_nui.cc, tizen_view_nui.*, tizen_renderer_nui_gl.*
- Remove the NUI_SUPPORT build path, dali libs and dali include dirs
  from BUILD.gn (keep CLIPBOARD_SUPPORT / tizen_clipboard.cc, which
  shared the api_version != "6.0" block)
- Remove FlutterDesktopViewCreateFromImageView and the now-unused
  FlutterDesktopViewProperties from the public header
- Drop NUI branches in flutter_tizen.cc, flutter_tizen_engine.cc,
  flutter_tizen_view.cc and tizen_renderer_egl.cc, and the
  HandleNuiKeyEvent path in tizen_input_method_context.*

Author: JSUYA

flutter/shell/platform/tizen/BUILD.gn

@@ -13,9 +13,6 @@ config("flutter_tizen_config") {
   include_dirs = [
     "${sysroot_path}/usr/include/appfw",
     "${sysroot_path}/usr/include/base",
-    "${sysroot_path}/usr/include/dali",
-    "${sysroot_path}/usr/include/dali-adaptor",
-    "${sysroot_path}/usr/include/dali-toolkit",
     "${sysroot_path}/usr/include/dlog",
     "${sysroot_path}/usr/include/ecore-1",
     "${sysroot_path}/usr/include/ecore-imf-1",
@@ -159,19 +156,10 @@ template("embedder") {
 
     if (api_version != "6.0") {
       sources += [
-        "flutter_tizen_nui.cc",
         "tizen_clipboard.cc",
-        "tizen_renderer_nui_gl.cc",
-        "tizen_view_nui.cc",
-      ]
-
-      libs += [
-        "dali2-adaptor",
-        "dali2-core",
       ]
 
       defines += [
-        "NUI_SUPPORT",
         "CLIPBOARD_SUPPORT",
       ]
     }

flutter/shell/platform/tizen/flutter_tizen.cc

@@ -15,10 +15,6 @@
 #include "flutter/shell/platform/tizen/logger.h"
 #include "flutter/shell/platform/tizen/public/flutter_platform_view.h"
 #include "flutter/shell/platform/tizen/tizen_view.h"
-#ifdef NUI_SUPPORT
-#include "flutter/shell/platform/tizen/tizen_renderer_egl.h"
-#include "flutter/shell/platform/tizen/tizen_view_nui.h"
-#endif
 #include "flutter/shell/platform/tizen/tizen_window.h"
 #include "flutter/shell/platform/tizen/tizen_window_ecore_wl2.h"
 
@@ -277,16 +273,8 @@ void FlutterDesktopViewOnKeyEvent(FlutterDesktopViewRef view,
                                   uint32_t scan_code,
                                   size_t timestamp,
                                   bool is_down) {
-#ifdef NUI_SUPPORT
-  if (auto* nui_view = dynamic_cast<flutter::TizenViewNui*>(
-          ViewFromHandle(view)->tizen_view())) {
-    nui_view->OnKey(device_name, device_class, device_subclass, key, string,
-                    nullptr, modifiers, scan_code, timestamp, is_down);
-  }
-#else
   ViewFromHandle(view)->OnKey(key, string, nullptr, modifiers, scan_code,
                               device_name, is_down);
-#endif
 }
 
 void FlutterDesktopViewSetFocus(FlutterDesktopViewRef view, bool focused) {

flutter/shell/platform/tizen/flutter_tizen_engine.cc

@@ -22,11 +22,6 @@
 #include "flutter/shell/platform/tizen/tizen_renderer_vulkan.h"
 #endif
 
-#ifdef NUI_SUPPORT
-#include "flutter/shell/platform/tizen/tizen_renderer_nui_gl.h"
-#include "flutter/shell/platform/tizen/tizen_view_nui.h"
-#endif
-
 namespace flutter {
 
 namespace {
@@ -90,13 +85,6 @@ std::unique_ptr<TizenRenderer> FlutterTizenEngine::CreateRenderer(
     FlutterDesktopRendererType renderer_type) {
   switch (renderer_type) {
     case FlutterDesktopRendererType::kEGL:
-#ifdef NUI_SUPPORT
-      if (auto* nui_view =
-              dynamic_cast<flutter::TizenViewNui*>(view_->tizen_view())) {
-        return std::make_unique<TizenRendererNuiGL>(
-            nui_view, project_->HasArgument("--enable-impeller"));
-      }
-#endif
       return std::make_unique<TizenRendererEgl>(
           view_->tizen_view(), project_->HasArgument("--enable-impeller"));
     case FlutterDesktopRendererType::kEVulkan:

flutter/shell/platform/tizen/flutter_tizen_nui.cc

@@ -8,9 +8,6 @@
 #include "flutter/shell/platform/tizen/logger.h"
 #include "flutter/shell/platform/tizen/system_utils.h"
 #include "flutter/shell/platform/tizen/tizen_view.h"
-#ifdef NUI_SUPPORT
-#include "flutter/shell/platform/tizen/tizen_view_nui.h"
-#endif
 #include "flutter/shell/platform/tizen/tizen_renderer_egl.h"
 #include "flutter/shell/platform/tizen/tizen_window.h"
 

flutter/shell/platform/tizen/flutter_tizen_view.cc

@@ -83,14 +83,6 @@ typedef struct {
   bool floating_menu_support;
 } FlutterDesktopWindowProperties;
 
-// Properties for configuring the initial settings of a Flutter view.
-typedef struct {
-  // The width of the view, or the maximum width if the value is zero.
-  int32_t width;
-  // The height of the view, or the maximum height if the value is zero.
-  int32_t height;
-} FlutterDesktopViewProperties;
-
 // Properties for configuring a Flutter engine instance.
 typedef struct {
   // The path to the flutter_assets folder for the application to be run.
@@ -185,18 +177,6 @@ FLUTTER_EXPORT FlutterDesktopViewRef FlutterDesktopViewCreateFromNewWindow(
     const FlutterDesktopWindowProperties& window_properties,
     FlutterDesktopEngineRef engine);
 
-// Creates a view that hosts and displays the given engine instance.
-//
-// The type of |image_view| must be Dali::Toolkit::ImageView*.
-// The type of |native_image_queue| must be Dali::NativeImageSourceQueue*.
-// @warning This API is a work-in-progress and may change.
-FLUTTER_EXPORT FlutterDesktopViewRef FlutterDesktopViewCreateFromImageView(
-    const FlutterDesktopViewProperties& view_properties,
-    FlutterDesktopEngineRef engine,
-    void* image_view,
-    void* native_image_queue,
-    int32_t default_window_id);
-
 // Destroys the view.
 //
 // The engine owned by the view will also be shut down implicitly.

flutter/shell/platform/tizen/public/flutter_tizen.h

@@ -173,12 +173,6 @@ TizenInputMethodContext::~TizenInputMethodContext() {
   UnregisterInputPanelEventCallback();
   UnregisterEventCallbacks();
 
-#ifdef NUI_SUPPORT
-  if (ecore_device_) {
-    ecore_device_del(ecore_device_);
-  }
-#endif
-
   if (imf_context_) {
     ecore_imf_context_del(imf_context_);
   }
@@ -207,50 +201,6 @@ bool TizenInputMethodContext::HandleEcoreEventKey(Ecore_Event_Key* event,
   }
 }
 
-#ifdef NUI_SUPPORT
-bool TizenInputMethodContext::HandleNuiKeyEvent(const char* device_name,
-                                                uint32_t device_class,
-                                                uint32_t device_subclass,
-                                                const char* key,
-                                                const char* string,
-                                                uint32_t modifiers,
-                                                uint32_t scan_code,
-                                                size_t timestamp,
-                                                bool is_down) {
-  Ecore_Event_Key event = {};
-  event.keyname = event.key = key ? key : "";
-  event.string = string ? string : "";
-  event.modifiers = modifiers;
-  event.keycode = scan_code;
-  event.timestamp = timestamp;
-  if (device_name) {
-    if (!ecore_device_) {
-      ecore_device_ = ecore_device_add();
-    }
-
-    event.dev = ecore_device_;
-    ecore_device_name_set(event.dev, device_name);
-    ecore_device_class_set(event.dev,
-                           static_cast<Ecore_IMF_Device_Class>(device_class));
-    ecore_device_subclass_set(
-        event.dev, static_cast<Ecore_IMF_Device_Subclass>(device_subclass));
-  }
-
-  Ecore_IMF_Event imf_event;
-  if (is_down) {
-    imf_event.key_down =
-        EcoreEventKeyToEcoreImfEvent<Ecore_IMF_Event_Key_Down>(&event);
-    return ecore_imf_context_filter_event(imf_context_,
-                                          ECORE_IMF_EVENT_KEY_DOWN, &imf_event);
-  } else {
-    imf_event.key_up =
-        EcoreEventKeyToEcoreImfEvent<Ecore_IMF_Event_Key_Up>(&event);
-    return ecore_imf_context_filter_event(imf_context_, ECORE_IMF_EVENT_KEY_UP,
-                                          &imf_event);
-  }
-}
-#endif
-
 InputPanelGeometry TizenInputMethodContext::GetInputPanelGeometry() {
   InputPanelGeometry geometry;
   if (!imf_context_) {

flutter/shell/platform/tizen/tizen_input_method_context.cc

@@ -31,18 +31,6 @@ class TizenInputMethodContext {
 
   bool HandleEcoreEventKey(Ecore_Event_Key* event, bool is_down);
 
-#ifdef NUI_SUPPORT
-  bool HandleNuiKeyEvent(const char* device_name,
-                         uint32_t device_class,
-                         uint32_t device_subclass,
-                         const char* key,
-                         const char* string,
-                         uint32_t modifiers,
-                         uint32_t scan_code,
-                         size_t timestamp,
-                         bool is_down);
-#endif
-
   InputPanelGeometry GetInputPanelGeometry();
 
   void ResetInputMethodContext();
@@ -95,9 +83,6 @@ class TizenInputMethodContext {
   void SetContextOptions();
   void SetInputPanelOptions();
 
-#ifdef NUI_SUPPORT
-  Ecore_Device* ecore_device_ = nullptr;
-#endif
   Ecore_IMF_Context* imf_context_ = nullptr;
   bool editing_active_ = false;
   OnCommit on_commit_;

flutter/shell/platform/tizen/tizen_input_method_context.h

@@ -8,9 +8,6 @@
 #include <Ecore_Wl2.h>
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
-#ifdef NUI_SUPPORT
-#include <dali/devel-api/adaptor-framework/native-image-source-queue.h>
-#endif
 #include <tbm_dummy_display.h>
 #include <tbm_surface.h>
 #include <tbm_surface_queue.h>
@@ -99,17 +96,6 @@ bool TizenRendererEgl::CreateSurface(void* render_target,
       egl_surface_ = eglCreateWindowSurface(
           egl_display_, egl_config_,
           reinterpret_cast<EGLNativeWindowType>(egl_window), attribs);
-    } else {
-#ifdef NUI_SUPPORT
-      Dali::NativeImageSourceQueuePtr dali_native_image_queue =
-          static_cast<Dali::NativeImageSourceQueue*>(render_target);
-      tbm_surface_queue_h tbm_surface_queue_ =
-          Dali::AnyCast<tbm_surface_queue_h>(
-              dali_native_image_queue->GetNativeImageSourceQueue());
-      egl_surface_ = eglCreateWindowSurface(
-          egl_display_, egl_config_,
-          reinterpret_cast<EGLNativeWindowType>(tbm_surface_queue_), attribs);
-#endif
     }
 
     if (egl_surface_ == EGL_NO_SURFACE) {