Commit c5cdbeb
committed
Reject --use-tcore on Tizen <10 and fix transitive includes
Three independent fixes that surfaced when somebody tried
'tools/gn --use-tcore --api-version 6.5':
1. tools/gn now rejects --use-tcore for api_version < 10.0 with a
clear error message. The tizen-core / tizen-core-imf /
tizen-core-wl packages are only published in the Tizen 11+
repository, so building the use_tcore variant against a 6.5/8.0
sysroot can never succeed.
2. Move '#include <tizen_core_wl.h>' from
tizen_input_method_context_tcore.h to the .cc. The public
interface only exposes tizen_core_imf_* types (events go
through void*), so the .h does not need the wl header. This
also stops the header from blowing up earlier-than-necessary
when somebody mis-configures the build.
3. external_texture_surface_vulkan_buffer_dma.cc: add explicit
'#include <unistd.h>' for close(). The Tizen 11 gcc 14 stdlib
no longer pulls it in transitively, so the experimental Vulkan
target failed to compile against sysroot-11.0.1 parent c8fe16a commit c5cdbeb
4 files changed
Lines changed: 15 additions & 1 deletion
File tree
- flutter/shell/platform/tizen
- tools
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
6 | 9 | | |
7 | 10 | | |
8 | 11 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
123 | 133 | | |
124 | 134 | | |
125 | 135 | | |
| |||
0 commit comments