Commit c8fe16a
committed
Gate unittests on USE_TCORE_WL too
The unittests cc files unconditionally include <tizen_core_wl.h>
and call tizen_core_wl_init(), which breaks ecore builds because
the header is not in the include path on non-tcore sysroots.
Conversely, the flutter_tizen_unittests executable target was
not getting the USE_TCORE_WL define, so a tcore build was pulling
in flutter_tizen_engine.h -> tizen_view_base.h -> the ecore
input-method header.
- Add #ifdef USE_TCORE_WL gates in
flutter_tizen_engine_unittest.cc and
flutter_tizen_texture_registrar_unittests.cc so each variant
uses the matching init call (tizen_core_wl_init / ecore_init).
- Propagate USE_TCORE_WL to the flutter_tizen_unittests target
in BUILD.gn when use_tcore is set.1 parent 1203622 commit c8fe16a
3 files changed
Lines changed: 26 additions & 2 deletions
File tree
- flutter/shell/platform/tizen
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
300 | 304 | | |
301 | 305 | | |
302 | 306 | | |
| |||
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
19 | 29 | | |
20 | 30 | | |
21 | 31 | | |
| |||
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
21 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
22 | 32 | | |
23 | 33 | | |
24 | 34 | | |
| |||
0 commit comments