Remove FlutterView (NUIFlutterView) embedding support#789
Conversation
Drop the NUIFlutterView API that hosted a Flutter screen inside a NUI app. It tracks the embedder-side removal of FlutterDesktopViewCreateFromImageView, whose Dali dependency keeps breaking against new Tizen versions and adds instability. - Delete NUIFlutterView.cs - Remove the FlutterDesktopViewCreateFromImageView P/Invoke from Interop.cs (FlutterDesktopViewProperties is kept; still used by the EFL FlutterDesktopViewCreateFromElmParent path) - Drop the now-dangling NUIFlutterView.cs Compile Remove item from the csproj
FlutterDesktopViewCreateFromElmParent (embed Flutter into an EFL Elementary parent) is the deprecated EFL embedding path. The embedder no longer exports the symbol (nm -D on the built flutter_tizen.so confirms it is absent), and nothing in flutter-tizen calls it, so the P/Invoke declaration was dangling dead code. - Remove the FlutterDesktopViewCreateFromElmParent P/Invoke - Remove the now-unused FlutterDesktopViewProperties marshalling struct (its only remaining reference was the ElmParent declaration; the NUIFlutterView user was already removed) Interop is an internal class, so these are not part of the public Tizen.Flutter.Embedding API surface; no external NuGet consumer breaks.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the NUIFlutterView class along with its associated interop structures and native method bindings, including FlutterDesktopViewProperties, FlutterDesktopViewCreateFromElmParent, and FlutterDesktopViewCreateFromImageView. It also cleans up the project file by removing the conditional compilation reference to the deleted NUIFlutterView.cs file. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The view-control interop entries were only used by the removed NUIFlutterView. Their native symbols are being removed from the embedder too, so drop the now-dangling P/Invoke declarations: FlutterDesktopViewOnKeyEvent, OnPointerEvent, Resize, SetFocus, IsFocused, GetNativeHandle. Interop is internal, so no public API breaks.
|
This patch is currently pending for a while to verify changes from DALi. |
2 participants
Drop the NUIFlutterView API that hosted a Flutter screen inside a NUI app. It tracks the embedder-side removal of
FlutterDesktopViewCreateFromImageView, whose Dali dependency keeps breaking against new Tizen versions and adds instability.
#788
flutter-tizen/embedder#184