[webview_flutter_lwe] Add integration test based on upstream v4.13.1 (#1056)

Author: seungsoo47

packages/webview_flutter_lwe/CHANGELOG.md

@@ -447,6 +447,36 @@ Future<void> main() async {
       final String? currentUrl = await controller.currentUrl();
       expect(currentUrl, secondaryUrl);
     });
+
+    testWidgets('can receive url changes', (WidgetTester tester) async {
+      final Completer<void> pageLoaded = Completer<void>();
+
+      final WebViewController controller = WebViewController();
+      unawaited(controller.setJavaScriptMode(JavaScriptMode.unrestricted));
+      unawaited(
+        controller.setNavigationDelegate(
+          NavigationDelegate(onPageFinished: (_) => pageLoaded.complete()),
+        ),
+      );
+      unawaited(controller.loadRequest(Uri.parse(blankPageEncoded)));
+
+      await tester.pumpWidget(WebViewWidget(controller: controller));
+
+      await pageLoaded.future;
+
+      final Completer<String> urlChangeCompleter = Completer<String>();
+      await controller.setNavigationDelegate(
+        NavigationDelegate(
+          onUrlChange: (UrlChange change) {
+            urlChangeCompleter.complete(change.url);
+          },
+        ),
+      );
+
+      await controller.runJavaScript('location.href = "$primaryUrl"');
+
+      await expectLater(urlChangeCompleter.future, completion(primaryUrl));
+    });
   });
 }
 

packages/webview_flutter_lwe/README.md

@@ -25,9 +25,11 @@ class LweWebViewController extends PlatformWebViewController {
 
   final LweWebView _webview;
   late LweNavigationDelegate _lweNavigationDelegate;
+  int? _viewId;
 
   /// Called when [TizenView] is created.
   void onCreate(int viewId) {
+    _viewId = viewId;
     if (_webview.hasNavigationDelegate) {
       _lweNavigationDelegate.onCreate(viewId);
     }
@@ -142,6 +144,15 @@ class LweWebViewController extends PlatformWebViewController {
   ) async {
     _lweNavigationDelegate = handler;
     _webview.hasNavigationDelegate = true;
+    // If the view has already been created, the previous delegate's method
+    // call handler is the one currently bound to the platform channel. Bind
+    // the new delegate now so its callbacks (e.g. onUrlChange, onPageFinished)
+    // are the ones invoked; otherwise events would keep going to the old
+    // delegate and be dropped.
+    final int? viewId = _viewId;
+    if (viewId != null) {
+      handler.onCreate(viewId);
+    }
   }
 
   @override
@@ -382,15 +393,21 @@ class LweNavigationDelegate extends PlatformNavigationDelegate {
   /// Creates a new [LweNavigationDelegate].
   LweNavigationDelegate(super.params) : super.implementation();
 
-  late final MethodChannel _navigationDelegateChannel;
+  late MethodChannel _navigationDelegateChannel;
+  int? _viewId;
   PageEventCallback? _onPageFinished;
   PageEventCallback? _onPageStarted;
   ProgressCallback? _onProgress;
   WebResourceErrorCallback? _onWebResourceError;
   NavigationRequestCallback? _onNavigationRequest;
+  UrlChangeCallback? _onUrlChange;
 
   /// Called when [TizenView] is created.
   void onCreate(int viewId) {
+    if (_viewId == viewId) {
+      return;
+    }
+    _viewId = viewId;
     _navigationDelegateChannel = MethodChannel(
       kLweNavigationDelegateChannelName + viewId.toString(),
     );
@@ -431,6 +448,11 @@ class LweNavigationDelegate extends PlatformNavigationDelegate {
             );
           }
           return null;
+        case 'onUrlChange':
+          if (_onUrlChange != null) {
+            _onUrlChange!(UrlChange(url: arguments['url']! as String));
+          }
+          return null;
       }
 
       throw MissingPluginException(
@@ -506,10 +528,7 @@ class LweNavigationDelegate extends PlatformNavigationDelegate {
 
   @override
   Future<void> setOnUrlChange(UrlChangeCallback onUrlChange) async {
-    throw UnimplementedError(
-      'This version of `LweNavigationDelegate` currently has no '
-      'implementation for `setOnUrlChange`',
-    );
+    _onUrlChange = onUrlChange;
   }
 
   @override

packages/webview_flutter_lwe/example/integration_test/webview_flutter_test.dart

@@ -2,7 +2,7 @@ name: webview_flutter_lwe
 description: Tizen implementation of the webview_flutter plugin backed by Lightweight Web Engine.
 homepage: https://github.com/flutter-tizen/plugins
 repository: https://github.com/flutter-tizen/plugins/tree/master/packages/webview_flutter_lwe
-version: 0.4.1
+version: 0.5.0
 
 environment:
   sdk: ^3.8.0