Skip to content

Commit daf5626

Browse files
committed
[tizen_rpc_port] Remove redundant zero-value Parcel round-trip tests
Zero doesn't exercise a different code path than other values in writeByte/writeInt16/writeInt64/writeArrayCount, so these cases only duplicated coverage already provided by the positive/negative/min/max round-trip tests.
1 parent 734204c commit daf5626

1 file changed

Lines changed: 1 addition & 23 deletions

File tree

packages/tizen_rpc_port/example/client/integration_test/tizen_rpc_port_test.dart

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ void main() {
7070
expect(parcel.readInt16(), 32767);
7171
});
7272

73-
testWidgets('round-trips zero', (WidgetTester _) async {
74-
final Parcel parcel = Parcel();
75-
parcel.writeInt16(0);
76-
expect(parcel.readInt16(), 0);
77-
});
78-
7973
testWidgets('round-trips negative value', (WidgetTester _) async {
8074
final Parcel parcel = Parcel();
8175
parcel.writeInt16(-1);
@@ -118,11 +112,6 @@ void main() {
118112
expect(parcel.readInt64(), value);
119113
});
120114

121-
testWidgets('round-trips zero', (WidgetTester _) async {
122-
final Parcel parcel = Parcel();
123-
parcel.writeInt64(0);
124-
expect(parcel.readInt64(), 0);
125-
});
126115
});
127116

128117
group('writeByte / readByte', () {
@@ -132,12 +121,6 @@ void main() {
132121
expect(parcel.readByte(), 0xab);
133122
});
134123

135-
testWidgets('round-trips zero', (WidgetTester _) async {
136-
final Parcel parcel = Parcel();
137-
parcel.writeByte(0);
138-
expect(parcel.readByte(), 0);
139-
});
140-
141124
testWidgets('round-trips maximum unsigned value', (WidgetTester _) async {
142125
final Parcel parcel = Parcel();
143126
parcel.writeByte(255);
@@ -162,17 +145,12 @@ void main() {
162145
});
163146

164147
group('writeArrayCount / readArrayCount', () {
165-
testWidgets('round-trips non-zero count', (WidgetTester _) async {
148+
testWidgets('round-trips a count', (WidgetTester _) async {
166149
final Parcel parcel = Parcel();
167150
parcel.writeArrayCount(42);
168151
expect(parcel.readArrayCount(), 42);
169152
});
170153

171-
testWidgets('round-trips zero count', (WidgetTester _) async {
172-
final Parcel parcel = Parcel();
173-
parcel.writeArrayCount(0);
174-
expect(parcel.readArrayCount(), 0);
175-
});
176154
});
177155

178156
group('write / read (burst byte array)', () {

0 commit comments

Comments
 (0)