Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/flutter_inappwebview/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.1

- Fix a crash when a webview is disposed.

## 0.1.0

- Initial release of `flutter_inappwebview_tizen`.
Expand Down
3 changes: 1 addition & 2 deletions packages/flutter_inappwebview/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ Add the internet privilege to the app manifest:
```yaml
dependencies:
flutter_inappwebview: ^6.1.5
flutter_inappwebview_tizen:
path: ../flutter_inappwebview_tizen
flutter_inappwebview_tizen: ^0.1.1
```

```dart
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_inappwebview/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: flutter_inappwebview_tizen
description: Tizen implementation of the flutter_inappwebview plugin.
homepage: https://github.com/flutter-tizen/plugins
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/flutter_inappwebview
version: 0.1.0
version: 0.1.1

environment:
sdk: ">=3.8.0 <4.0.0"
Expand Down
13 changes: 7 additions & 6 deletions packages/flutter_inappwebview/tizen/src/webview.cc
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,8 @@ void WebView::Dispose() {
evas_object_del(webview_instance_);
webview_instance_ = nullptr;
}
if (ecore_evas_) {
ecore_evas_free(ecore_evas_);
ecore_evas_ = nullptr;
}

ecore_evas_ = nullptr;

// ewk_shutdown();
}
Expand Down Expand Up @@ -541,15 +539,18 @@ bool WebView::InitWebView() {
// temporarily comment out ewk_init() and ewk_shutdown(). It can be reverted
// depending on updates to chromium-efl.
// ewk_init();
ecore_evas_ = ecore_evas_new("wayland_egl", 0, 0, 1, 1, 0);
static Ecore_Evas* shared_ecore_evas = nullptr;
if (!shared_ecore_evas) {
shared_ecore_evas = ecore_evas_new("wayland_egl", 0, 0, 1, 1, 0);
}
ecore_evas_ = shared_ecore_evas;
if (!ecore_evas_) {
LOG_ERROR("Failed to create Ecore_Evas for the WebView.");
return false;
}

webview_instance_ = ewk_view_add(ecore_evas_get(ecore_evas_));
if (!webview_instance_) {
ecore_evas_free(ecore_evas_);
ecore_evas_ = nullptr;
return false;
}
Expand Down
Loading